Alon Bar-Lev has posted comments on this change. Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33323/2/build/validations/pom.xml File build/validations/pom.xml: Line 21: <groupId>org.antlr</groupId> Line 22: <artifactId>antlr4-runtime</artifactId> Line 23: <version>4.2.2</version> Line 24: <scope>test</scope> Line 25: </dependency> > its a runtime dep which is declared at "runtime" in utils but here we need can't we have this at scope = test in utils? won't it be easier to have this managed at source? Line 26: </dependencies> Line 27: -- To view, visit http://gerrit.ovirt.org/33323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
