Gilad Chaplik has posted comments on this change. Change subject: webadmin: make it more obvious that thread as cores is enabled ......................................................................
Patch Set 1: Code-Review+1 (4 comments) minor comments.. looks good in general. http://gerrit.ovirt.org/#/c/33485/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 64: result = prime * result + ((vdsGroupCpuName == null) ? 0 : vdsGroupCpuName.hashCode()); Line 65: result = prime * result + ((vdsGroupDescription == null) ? 0 : vdsGroupDescription.hashCode()); Line 66: result = prime * result + ((vdsGroupName == null) ? 0 : vdsGroupName.hashCode()); Line 67: result = prime * result + ((vdsGroupVirtService == null) ? 0 : vdsGroupVirtService.hashCode()); Line 68: result = prime * result + ((vdsGroupGlusterService == null) ? 0 : vdsGroupGlusterService.hashCode()); not sure if it's necessary, but consider adding it here for consistency (also in #equals and #clone). Line 69: result = prime * result + (balloonEnabled ? 0 : 1); Line 70: return result; Line 71: } Line 72: http://gerrit.ovirt.org/#/c/33485/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java: Line 361: entity.setNumaSupport(rs.getBoolean("is_numa_supported")); Line 362: entity.setLiveSnapshotSupport(rs.getBoolean("is_live_snapshot_supported")); Line 363: entity.setLiveMergeSupport(rs.getBoolean("is_live_merge_supported")); Line 364: entity.setBalloonEnabled(rs.getBoolean("enable_balloon")); Line 365: entity.setCountThreadsAsCores(rs.getBoolean("count_threads_as_cores")); nice, you've got it for free :) Line 366: return entity; Line 367: } Line 368: } http://gerrit.ovirt.org/#/c/33485/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java: Line 258: coresPerSocketBuff.append(coresPerSocket); Line 259: Line 260: if (vds.getCountThreadsAsCores()) { Line 261: coresPerSocketBuff.append(" ("); //$NON-NLS-1$ Line 262: coresPerSocketBuff.append(vds.getCpuThreads()); I'd use ConstantsManager.getInstance().getMessages().xyz(coresPer, cpuThreads)- and add a label there for cpuThreads. . Line 263: coresPerSocketBuff.append(")"); //$NON-NLS-1$ Line 264: } Line 265: Line 266: setCoresPerSocket(coresPerSocketBuff.toString()); http://gerrit.ovirt.org/#/c/33485/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 786 Line 787 Line 788 Line 789 Line 790 remove -- To view, visit http://gerrit.ovirt.org/33485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fb9d28f3b125a9104fec5f3a887efdbf711b037 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
