Allon Mureinik has posted comments on this change. Change subject: core: Add a lock when detaching Storage from Data Center ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Please verify (and fix the nit there) http://gerrit.ovirt.org/#/c/33461/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java: Line 22: import org.ovirt.engine.core.utils.transaction.TransactionMethod; Line 23: import org.ovirt.engine.core.utils.transaction.TransactionSupport; Line 24: Line 25: import java.util.Collections; Line 26: import java.util.Map; Should be on top - please fix your formatter. Line 27: Line 28: @NonTransactiveCommandAttribute(forceCompensation=true) Line 29: public class DetachStorageDomainFromPoolCommand<T extends DetachStorageDomainFromPoolParameters> extends Line 30: StorageDomainCommandBase<T> { -- To view, visit http://gerrit.ovirt.org/33461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c6be592ad6d71579ce0aa20926856cbca23d44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
