Alon Bar-Lev has posted comments on this change. Change subject: uutils: Extract connection class ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33479/2/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/http/Connection.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/http/Connection.java: Line 90: return this; Line 91: } Line 92: Line 93: Line 94: public void create() throws IOException, GeneralSecurityException { > As this is in a package of http, I would pefer HttpURLConnection. ok, so return HttpURLConnection Line 95: connection = new URL(url).openConnection(); Line 96: connection.setDoInput(true); Line 97: connection.setDoOutput(false); Line 98: connection.setAllowUserInteraction(false); http://gerrit.ovirt.org/#/c/33479/2/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/servlet/ProxyServletBase.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/servlet/ProxyServletBase.java: Line 136: Line 137: if (url == null) { Line 138: response.sendError(response.SC_NOT_FOUND, "Cannot proxy, no URL is configured."); Line 139: } else { Line 140: Connection connection; > We should hold HttpURLConnection , IMHO ok, raise exception in create if URL is not http. Line 141: try { Line 142: connection = createConnection(new URL(mergeQuery(url, request.getQueryString()))); Line 143: } catch (Exception e) { Line 144: throw new ServletException(e); -- To view, visit http://gerrit.ovirt.org/33479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
