Shubhendu Tripathi has posted comments on this change. Change subject: engine: Bll to resume geo-rep session ......................................................................
Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/32935/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepGlusterVolumeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepGlusterVolumeCommand.java: Line 11: Line 12: public class ResumeGeoRepGlusterVolumeCommand extends GeoRepSessionCommandBase<GlusterVolumeGeoRepSessionParameters>{ Line 13: Line 14: private GlusterVolumeGeoRepSessionParameters parameters; Line 15: private GlusterGeoRepSession session; Below I can see most of the cases getGeoRepSession() is called explicitly, so in that do we really need this variable?? Line 16: Line 17: public ResumeGeoRepGlusterVolumeCommand(GlusterVolumeGeoRepSessionParameters params) { Line 18: super(params); Line 19: } http://gerrit.ovirt.org/#/c/32935/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 298: GLUSTER_VOLUME_REBALANCE_START_FAILED(4013, AuditLogSeverity.ERROR), Line 299: GLUSTER_VOLUME_REMOVE_BRICKS(4014), Line 300: GLUSTER_VOLUME_REMOVE_BRICKS_FAILED(4015, AuditLogSeverity.ERROR), Line 301: GLUSTER_VOLUME_GEO_REP_RESUME_FAILED(4597, AuditLogSeverity.ERROR), Line 302: GLUSTER_VOLUME_GEO_REP_RESUME(4596), Reverse the order of declaration Line 303: GLUSTER_VOLUME_REPLACE_BRICK_FAILED(4016, AuditLogSeverity.ERROR), Line 304: GLUSTER_VOLUME_REPLACE_BRICK_START(4017), Line 305: GLUSTER_VOLUME_REPLACE_BRICK_START_FAILED(4018, AuditLogSeverity.ERROR), Line 306: GLUSTER_VOLUME_ADD_BRICK(4019), http://gerrit.ovirt.org/#/c/32935/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 299: StartRemoveGlusterVolumeBricks(1422, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 300: StopRemoveGlusterVolumeBricks(1423, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 301: CommitRemoveGlusterVolumeBricks(1424, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 302: RefreshGlusterVolumeDetails(1425, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 303: GlusterVolumeGeoRepStart(1426, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Both the codes are 1426 ?? Line 304: ResumeGeoRepSession(1426, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 305: Line 306: // Scheduling Policy Line 307: AddClusterPolicy(1450, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), http://gerrit.ovirt.org/#/c/32935/6/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java: Line 1: package org.ovirt.engine.ui.uicompat; Line 2: Line 3: import org.ovirt.engine.core.common.AuditLogSeverity; ?? Line 4: Line 5: import com.google.gwt.i18n.client.ConstantsWithLookup; Line 6: Line 7: public interface LocalizedEnums extends ConstantsWithLookup { -- To view, visit http://gerrit.ovirt.org/32935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8a94c84758d89096c8726b9c11d5d0990a7002 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
