Simone Tiraboschi has posted comments on this change. Change subject: pacaking: setup: fixing iptables review dialog ......................................................................
Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/33467/8/packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py File packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py: Line 141: if os.path.isfile(osetupcons.FileLocations.OVIRT_IPTABLES_EXAMPLE): Line 142: with open( Line 143: osetupcons.FileLocations.OVIRT_IPTABLES_EXAMPLE, Line 144: 'r' Line 145: ) as preexample: > Sorry, perhaps also this: prev_setup_example? Done Line 146: preexipr = preexample.read().splitlines() Line 147: diffprecur = difflib.unified_diff( Line 148: current_rules, Line 149: preexipr, Line 142: with open( Line 143: osetupcons.FileLocations.OVIRT_IPTABLES_EXAMPLE, Line 144: 'r' Line 145: ) as preexample: Line 146: preexipr = preexample.read().splitlines() > prev_setup_rules? Done Line 147: diffprecur = difflib.unified_diff( Line 148: current_rules, Line 149: preexipr, Line 150: ) Line 143: osetupcons.FileLocations.OVIRT_IPTABLES_EXAMPLE, Line 144: 'r' Line 145: ) as preexample: Line 146: preexipr = preexample.read().splitlines() Line 147: diffprecur = difflib.unified_diff( > perhaps just 'diff', or diff_prev_cur? Done Line 148: current_rules, Line 149: preexipr, Line 150: ) Line 151: diff_lines = ''.join(diffprecur) -- To view, visit http://gerrit.ovirt.org/33467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f16a90a074052226882d76fc80918ed276d379c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
