Gilad Chaplik has posted comments on this change. Change subject: core: persist disk image parameters for live migration ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33483/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java: Line 101: (new image_storage_domain_map(di.getImageId(), Line 102: targetStorageDomainId, Line 103: targetQuota, Line 104: targetDiskProfile)); Line 105: if (sourceQuotaId == null) { > please add comment explaining the use-case of the workaround Done Line 106: sourceQuotaId = di.getQuotaId(); Line 107: } Line 108: Line 109: if (sourceDiskProfileId == null) { -- To view, visit http://gerrit.ovirt.org/33483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
