Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/33458/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 301: Line 302: private void runHttpModificatioMethod(HttpMethodType httpMethod, String relativeUrl, String body) { Line 303: HttpURLConnection connection = createConnection(relativeUrl); Line 304: try { Line 305: connection.setRequestProperty("Content-Type", "application/json"); > btw, didn't you mean to provide the charset within the content-type? yes... whatever matches the bellow conversion. Line 306: connection.setDoOutput(true); Line 307: connection.setRequestMethod(httpMethod.toString()); Line 308: if (body != null) { Line 309: byte[] bytes = body.getBytes(Charset.forName("UTF-8")); -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
