Daniel Erez has uploaded a new change for review. Change subject: core: LiveSnapshotTaskHandler - remove setExecutionContext(null) ......................................................................
core: LiveSnapshotTaskHandler - remove setExecutionContext(null) LiveSnapshotTaskHandler -> endSuccessfully / endWithFailure: remove 'enclosingCommand.setExecutionContext(null)' to avoid an NPE on CommandBase -> buildCommandEntity. Change-Id: I45ee451b62ff1f41f8ad03f707c105c1db70a768 Bug-Url: https://bugzilla.redhat.com/1147971 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/33617/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java index c78313d..8debf85 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java @@ -80,7 +80,6 @@ } ExecutionHandler.endJob(enclosingCommand.getExecutionContext(), true); - enclosingCommand.setExecutionContext(null); } private void updateDestinationImageId(LiveMigrateDiskParameters parameters) { @@ -114,7 +113,6 @@ unlockAllDiskSnapshots(); ExecutionHandler.endJob(enclosingCommand.getExecutionContext(), false); - enclosingCommand.setExecutionContext(null); enclosingCommand.getReturnValue().setSucceeded(true); } -- To view, visit http://gerrit.ovirt.org/33617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45ee451b62ff1f41f8ad03f707c105c1db70a768 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
