Eli Mesika has posted comments on this change. Change subject: db:add tab/col name validation to common functions ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32959/1/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 31: v_sql := 'ALTER TABLE ' || v_table || ' DROP COLUMN ' || v_column; Line 32: EXECUTE v_sql; Line 33: end; Line 34: else Line 35: RAISE EXCEPTION 'Column % does not exist in %', v_column, v_table; > Shirly is correct, but I think if we can throw a more exact exception, it i As those functions are for developers I think that 'Table T or Column C " is OK Line 36: end if; Line 37: end;$procedure$ Line 38: LANGUAGE plpgsql; Line 39: -- To view, visit http://gerrit.ovirt.org/32959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5f087f3d47b4f36bb99151a21c2e1016d77b64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
