Federico Simoncelli has uploaded a new change for review. Change subject: vdsbroker: no spm failover on attach iso domain failure ......................................................................
vdsbroker: no spm failover on attach iso domain failure Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1140430 Change-Id: I93500e5493b7e963c3b218520e5f6e7b96e3fe5f Signed-off-by: Federico Simoncelli <[email protected]> (cherry picked from commit e3d5250e083da6246535e1fa4c7a2d0196ca1a7b) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/33665/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java index ff072d4..210d608 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java @@ -1,7 +1,6 @@ package org.ovirt.engine.core.vdsbroker.irsbroker; import org.ovirt.engine.core.common.businessentities.StorageDomain; -import org.ovirt.engine.core.common.businessentities.StorageDomainType; import org.ovirt.engine.core.common.vdscommands.AttachStorageDomainVDSCommandParameters; import org.ovirt.engine.core.dal.dbbroker.DbFacade; import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSExceptionBase; @@ -22,7 +21,7 @@ @Override protected VDSExceptionBase createDefaultConcreteException(String errorMessage) { StorageDomain domainFromDb = DbFacade.getInstance().getStorageDomainDao().get(getParameters().getStorageDomainId()); - if (domainFromDb == null || domainFromDb.getStorageDomainType() == StorageDomainType.ImportExport) { + if (domainFromDb == null || !domainFromDb.getStorageDomainType().isDataDomain()) { return new IrsOperationFailedNoFailoverException(errorMessage); } return super.createDefaultConcreteException(errorMessage); -- To view, visit http://gerrit.ovirt.org/33665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I93500e5493b7e963c3b218520e5f6e7b96e3fe5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Federico Simoncelli <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
