Maor Lipchuk has posted comments on this change.

Change subject: core:Edit job message referencing template(#818295)
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 467:                     (getVmTemplateName() == null) ? "" : 
getVmTemplateName());
Storage pool will get from the StorageHandlingCommandBase

import VM is net related to this patch since this patch only regards template, 
the fix for VM should be in another patch.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
Line 266:             
jobProperties.put(VdcObjectType.StoragePool.toString().toLowerCase(), 
getStoragePoolName());
Done.

Line 267:             
jobProperties.put(VdcObjectType.VmTemplate.toString().toLowerCase(), 
getVmTemplateName());
Done.

--
To view, visit http://gerrit.ovirt.org/6353
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5d41889360cf7bc309e9e9a49fb0298269c7984
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to