Yair Zaslavsky has posted comments on this change. Change subject: uutils: Extract connectionBuilder class ......................................................................
Patch Set 13: (4 comments) http://gerrit.ovirt.org/#/c/33479/13/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java: Line 24: public class HttpURLConnectionBuilder { Line 25: Line 26: private Boolean verifyHost = true; Line 27: private Boolean verifyChain = true; Line 28: private String httpsProtocol; > please default to "TLSv1" or we get exception if not set. Done Line 29: private String trustManagerAlgorithm; Line 30: private String trustStore; Line 31: private String trustStoreType; Line 32: private String trustStorePassword = "changeit"; Line 25: Line 26: private Boolean verifyHost = true; Line 27: private Boolean verifyChain = true; Line 28: private String httpsProtocol; Line 29: private String trustManagerAlgorithm; > private String trustManagerAlgorithm = TrustManagerFactory.getDefaultAlgori Done Line 30: private String trustStore; Line 31: private String trustStoreType; Line 32: private String trustStorePassword = "changeit"; Line 33: private Integer readTimeout; Line 27: private Boolean verifyChain = true; Line 28: private String httpsProtocol; Line 29: private String trustManagerAlgorithm; Line 30: private String trustStore; Line 31: private String trustStoreType; > private String trustStoreType = KeyStore.getDefaultType();$ Done Line 32: private String trustStorePassword = "changeit"; Line 33: private Integer readTimeout; Line 34: private URL url; Line 35: Line 114: return create(null); Line 115: } Line 116: Line 117: Line 118: public HttpURLConnection create(final List<X509Certificate> chain) throws IOException, GeneralSecurityException { > yes. this comment was before we discussed what it is. Done Line 119: URLConnection connection = url.openConnection(); Line 120: connection.setAllowUserInteraction(false); Line 121: connection.setUseCaches(false); Line 122: if (readTimeout != null) { -- To view, visit http://gerrit.ovirt.org/33479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
