Martin Mucha has posted comments on this change. Change subject: webadmin: removed ugly if-else chain ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33619/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3224: public Guid getEntityGuid(Object entity) { Line 3225: Line 3226: if (entity instanceof BusinessEntity) { Line 3227: //BusinessEntity can have lot of different ID types, but from this context it cannot be determined. Line 3228: Object id = getEntityGuid((BusinessEntity<?>) entity); > simple. Instanceof operator is shit. It's usage is indication of design fai ps. if we're able to make all three entities descendant of BusinessEntity (I do not know it's exact meaning, but I think we could), we can throw all this method away keeping only the "healthy&clean" one in code base. Line 3229: Line 3230: //check whether result can be casted to Guid, otherwise continue with explicit rules. Line 3231: if (id instanceof Guid) { Line 3232: return (Guid) id; -- To view, visit http://gerrit.ovirt.org/33619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic716dc67b90c1d575de14c40b504c984bf0467f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
