Yair Zaslavsky has posted comments on this change. Change subject: core: Store only single certificate ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/33717/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateChainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateChainCommand.java: Line 73 Line 74 Line 75 Line 76 Line 77 > Why do we need this? what do you mean? this is what stores the keystore. Line 65: } Line 66: Line 67: try { Line 68: Certificate certificate = chain.get(chain.size() - 1); Line 69: String alias = Guid.newGuid().toString(); > please do not use compat classes in new code. I'm fine with that, although barei n mind in bll we are "stuck with guid" anyway. Line 70: ks.setCertificateEntry(alias, certificate); Line 71: ExternalTrustStoreInitializer.setTrustStore(ks); Line 72: setSucceeded(true); Line 73: } catch (Throwable e) { -- To view, visit http://gerrit.ovirt.org/33717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9bd8cd7f913cf23eca839452b6e113f749966f7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
