Yair Zaslavsky has posted comments on this change. Change subject: core: removed pointless caching. ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/29586/9/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java: Line 50: final String key = logType.name(); Line 51: try { Line 52: return resourceBundle.getString(key); Line 53: } catch (Exception e) { Line 54: log.error("Key '" + key + "' is not translated in '"+getResourceBundleName()+"'"); I would prefer if you use String.format here. Also, have hyou thought of log.debug the stacktrace? Line 55: return null; Line 56: } Line 57: } Line 58: -- To view, visit http://gerrit.ovirt.org/29586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7eb5e71aafb8d8fde253d8713fe6cb7f870d3093 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
