Yair Zaslavsky has posted comments on this change. Change subject: aaa: Suppress compiler warnings for unchecked cast ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33682/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java: Line 101: } Line 102: ); Line 103: } Line 104: Line 105: @SuppressWarnings("unchecked") Imho there is some inconsistency with the previous method - in the previous method you changed, you added the annotation on a specific check, why do you do it here for the entire method? In addition, see my comment about mvn clean install. Line 106: @Override Line 107: public void doFilter(ServletRequest req, ServletResponse rsp, FilterChain chain) Line 108: throws IOException, ServletException { Line 109: -- To view, visit http://gerrit.ovirt.org/33682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
