Moti Asayag has posted comments on this change. Change subject: utils: Suppress warnings for deprecation and add appropriate TODO message ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/33685/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java: Line 20: import org.ovirt.engine.core.compat.RegexOptions; Line 21: import org.ovirt.engine.core.compat.Version; Line 22: Line 23: // TODO refactor to avoid use of deprecated classes in compat module Line 24: @SuppressWarnings("deprecation") please move the suppression to the method level. Line 25: public class OvfVmWriter extends OvfWriter { Line 26: private static final String EXPORT_ONLY_PREFIX = "exportonly_"; Line 27: private OsRepository osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); Line 28: http://gerrit.ovirt.org/#/c/33685/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java: Line 15: import org.ovirt.engine.core.utils.log.Log; Line 16: import org.ovirt.engine.core.utils.log.LogFactory; Line 17: Line 18: // TODO refactor to avoid use of deprecated classes in compat module Line 19: @SuppressWarnings("deprecation") please move the suppression to the method level. Line 20: public class VdsFenceOptions implements Serializable { Line 21: Line 22: private static final long serialVersionUID = -8832636627473217232L; Line 23: private static final String COMMA = ","; -- To view, visit http://gerrit.ovirt.org/33685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5fe8816e006276fce3300ece657be8de21823f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
