Michael Pasternak has posted comments on this change. Change subject: restapi: Problem Updating Storage Domain ......................................................................
Patch Set 1: Do not submit (1 inline comment) this should be treated at BE not on a client side, if in future will be added support for more SD props, i don't want maintaining each prop adding it in the api, bottom line we should pass entire SD as we did and BE should ignore what is not relevant .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java Line 240: } this should be treated at BE not on a client side, if in future will be added support for more SD props, i don't want maintaining each prop adding it in the api, bottom line we should pass entire SD as we did and BE should ignore what is not relevant -- To view, visit http://gerrit.ovirt.org/6709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae432bd53f3f03d950ed5f37f7d39297984805b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
