Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: fixing remote engine pki common code usage on upgrades ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33786/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py: Line 93 Line 94 Line 95 Line 96 Line 97 > to here Done http://gerrit.ovirt.org/#/c/33786/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py: Line 81: os.path.exists( Line 82: oreportscons.FileLocations.OVIRT_ENGINE_PKI_REPORTS_JBOSS_KEY Line 83: ) and os.path.exists( Line 84: oreportscons.FileLocations.OVIRT_ENGINE_PKI_REPORTS_JBOSS_CERT Line 85: ) > Is this really needed? The common code in enroll_cert already does this. Ap Yes, I didn't noticed that enroll_cert already check it. WSP is a special case too cause it also need the engine cert. Line 86: ) Line 87: Line 88: if not reports_jboss_pki_found: Line 89: self._enrolldata = remote_engine.EnrollCert( -- To view, visit http://gerrit.ovirt.org/33786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I011db10e16bb931c1610bc6645410917e722218d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
