Moti Asayag has posted comments on this change. Change subject: engine: refactor CollectVdsNetworkDataVDSCommand ......................................................................
Patch Set 3: (3 comments) well...if we opened that door...here are couple more :) http://gerrit.ovirt.org/#/c/33905/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java: Line 152: } Line 153: Line 154: private Collection<Network> findNetworksOnInterfaces(Collection<VdsNetworkInterface> ifaces, Line 155: Map<String, Network> clusterNetworksByName) { Line 156: final Collection<Network> networks = new ArrayList<Network>(); here as well - type can be omitted Line 157: for (VdsNetworkInterface iface : ifaces) { Line 158: final String interfaceNetworkName = iface.getNetworkName(); Line 159: if (clusterNetworksByName.containsKey(interfaceNetworkName)) { Line 160: final Network network = clusterNetworksByName.get(interfaceNetworkName); Line 178: return managementNetwork; Line 179: } Line 180: Line 181: private void logUnsynchronizedNetworks(VDS host, Map<String, Network> networks) { Line 182: List<String> networkNames = new ArrayList<String>(); here as well - type can be omitted Line 183: NetworkQoSDao qosDao = DbFacade.getInstance().getNetworkQosDao(); Line 184: Line 185: for (VdsNetworkInterface iface : host.getInterfaces()) { Line 186: Network network = networks.get(iface.getNetworkName()); Line 277: } Line 278: Line 279: private String getMissingOperationalClusterNetworks(VDS host, List<Network> clusterNetworks) { Line 280: Map<String, Network> hostNetworksByName = Entities.entitiesByName(host.getNetworks()); Line 281: List<String> networkNames = new ArrayList<String>(); here as well - type can be omitted Line 282: Line 283: for (Network net : clusterNetworks) { Line 284: if (net.getCluster().getStatus() == OPERATIONAL && Line 285: net.getCluster().isRequired() && -- To view, visit http://gerrit.ovirt.org/33905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I798abe6597c06df873ac94f61981ff1dccc07bc8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
