Ravi Nori has posted comments on this change. Change subject: webadmin: Simplify report redirect ......................................................................
Patch Set 8: Code-Review+1 (1 comment) Minor comment, need input from Yaniv http://gerrit.ovirt.org/#/c/33550/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/HtmlParameters.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/HtmlParameters.java: Line 49: /** Line 50: * Parse the parsed in URL, and take any parameters found and put them in this {@code HtmlParameters} object. Line 51: * This is a naive parse method. Line 52: * This will not handle duplicate parameters, nor empty ones, nor hash tags, or partials. Line 53: * So this will fail: ?a=b&c&d&e=f#g;h even though it is a valid URL. Yaniv what do you think about the restriction? Line 54: * @param baseUrl The {@code String} URL to parse. Line 55: */ Line 56: public void parseUrlParams(String baseUrl) { Line 57: if (baseUrl.indexOf('?') >= 0) { -- To view, visit http://gerrit.ovirt.org/33550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4718bf7f734ea72d2494fc463a87cb7675df0c4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
