Alon Bar-Lev has posted comments on this change. Change subject: tools: Replace log4j with JUL as backend for notifier ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/33774/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java: Line 34: try { Line 35: prop = NotificationProperties.getInstance(); Line 36: Line 37: if (prop.isConfigured(LOG_LEVEL)) { Line 38: JavaLoggingUtils.setLogLevel(prop.getProperty(LOG_LEVEL)); > There's no need to set always. By default it's INFO using information speci you can always assume you have configuration in the service config. Line 39: } Line 40: Line 41: prop.validate(); Line 42: notificationService = new NotificationService(prop); http://gerrit.ovirt.org/#/c/33774/4/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in: Line 76: # Line 77: # One of FINE, INFO, WARNING, SEVERE. If it's empty, then INFO is used. Line 78: # Line 79: LOG_LEVEL= Line 80: > You can do this by modifying notifier-logging.properties (for development), we can process the logging properties during engine start and not at build time... then we can control the output to be to console if in debug... but I agree it is not that important as tail -f does the trick as well :) Line 81: #-------------------------------------# Line 82: # Notification Service Configuration: # Line 83: #-------------------------------------# Line 84: # Interval (in seconds) between iterations of dispatching messages to subscribers. Default is 120 seconds. -- To view, visit http://gerrit.ovirt.org/33774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10216f8530e23c43942cdf28fe2cb306d7e6df71 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
