Liron Aravot has posted comments on this change. Change subject: core: added information to ConnectStorageVDScommand logs (#835546) ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStorageServerVDSCommandParameters.java Line 48: sb.append(con.toString()); I don't agree with you on that one - if someone would like to change the toString() implementation he won't know where its used without this explicit call, as there is no reasonable scenario that someone would add even by mistake null to this list, i'd prefer leave the call as it is. -- To view, visit http://gerrit.ovirt.org/5748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b613bd18ef9586040862cac56373705f3e65237 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
