Martin Peřina has posted comments on this change. Change subject: tools: Replace log4j with slf4j as frontend in engine-config ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33756/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java: Line 49: } Line 50: catch (Exception exception) { Line 51: String msg = "Failed to decrypt the current value."; Line 52: console.writeLine(msg); Line 53: log.error("", exception); > probably better to write "Exception" instead of empty in these cases. Done Line 54: throw new GeneralSecurityException(msg); Line 55: } Line 56: } Line 57: -- To view, visit http://gerrit.ovirt.org/33756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc3d2a507f51c11b468c6af33a8f714545d3d695 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
