Livnat Peer has posted comments on this change.
Change subject: core: Wrong bootproto for non-bridged networks(#842986)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 883:
You need to add supportBridgesReportByVDSM config options with different value
for the different versions.
Line 885: VdsNetworkInterface iface = null;
How about -
String interfaceName = (String) network.get("interface");
Line 899: } else {
- unify the port iteration
- issue audit log
--
To view, visit http://gerrit.ovirt.org/6771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie60ac43e27d90c8de2b434a506651360fedd6d9c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
