Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: remote_engine: support older paramiko
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/34055/2/packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py
File 
packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py:

Line 67: 
Line 68:         def _ssh_get_port(self):
Line 69:             port_valid = False
Line 70:             key = osetupcons.ConfigEnv.REMOTE_ENGINE_HOST_SSH_PORT
Line 71:             port = self.environment[key]
This fixes https://bugzilla.redhat.com/1150508
Line 72:             interactive = False
Line 73:             while not port_valid:
Line 74:                 try:
Line 75:                     if port is None:


-- 
To view, visit http://gerrit.ovirt.org/34055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I730d15670bd9aa5dc68d6d1f93157c5895429491
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to