Vojtech Szocs has posted comments on this change.
Change subject: restapi,userportal,webadmin: secure cookie
......................................................................
Patch Set 4: Code-Review+2
Patch looks good, just one note - if we wanted to support secure cookies also
for development (most likely not, though) - we could use Maven resource
filtering:
* set Maven property like <useSecureCookies>false</useSecureCookies> with
override through -DuseSecureCookies=true
* tell maven-resources-plugin to filter web.xml files, replacing
${useSecureCookies} with actual property value
Anyway, I think that secure cookies are not too relevant for development, so
above is just FYI info :-)
--
To view, visit http://gerrit.ovirt.org/33981
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4de909c25ec7b28d12dc7e325c366962c85d32a7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
