Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: new implementation for apache-sshd usage
......................................................................
Patch Set 4: (6 inline comments)
....................................................
File backend/manager/modules/utils/pom.xml
Line 156: <excludes>
whitespace, please remove.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/MinaInstallWrapper.java
Line 77: private boolean _doConnect(String server, Credentials creds) {
drop the underscore here.
Line 87: private boolean _doConnect(String server, Credentials creds, long
timeout) {
same
Line 217: public void finalize() throws Exception {
IMHO finalize is bad practice.
Can't we shut down the wrapper in explicit way?
Line 329: public void finallize() {
Once again, bad practice + spelling mistake on the way.
Line 345: _callbackAddMessage(message);
Can you please drop the under score?
--
To view, visit http://gerrit.ovirt.org/6722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50ba60f2db364114907485da3074feb714615e0c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
