Martin Peřina has posted comments on this change. Change subject: userportal,webadmin: lazy load list models ......................................................................
Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/34193/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java: Line 145: Line 146: protected void updateReportsAvailability() { Line 147: // if (CommonModelManager.instance() != null) { Line 148: // CommonModelManager.instance().updateReportsAvailability(); Line 149: // } If code is not needed, please remove it Line 150: } Line 151: Line 152: /** Line 153: * <p> http://gerrit.ovirt.org/#/c/34193/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java: Line 81: private final Provider<PoolListModel> poolListModelProvider; Line 82: private final Provider<TemplateListModel> templateListModelProvider; Line 83: private final Provider<UserListModel> userListModelProvider; Line 84: private final Provider<EventListModel> eventListModelProvider; Line 85: // private final Provider<ReportsListModel> reportsListModelProvider; If code is not needed, please remove it Line 86: private final Provider<QuotaListModel> quotaListModelProvider; Line 87: private final Provider<VolumeListModel> volumeListModelProvider; Line 88: private final Provider<DiskListModel> diskListModelProvider; Line 89: private final Provider<NetworkListModel> networkListModelProvider; Line 110: final Provider<PoolListModel> poolListModelProvider, Line 111: final Provider<TemplateListModel> templateListModelProvider, Line 112: final Provider<UserListModel> userListModelProvider, Line 113: final Provider<EventListModel> eventListModelProvider, Line 114: // final Provider<ReportsListModel> reportsListModelProvider, If code is not needed, please remove it Line 115: final Provider<QuotaListModel> quotaListModelProvider, Line 116: final Provider<VolumeListModel> volumeListModelProvider, Line 117: final Provider<DiskListModel> diskListModelProvider, Line 118: final Provider<NetworkListModel> networkListModelProvider, Line 138: this.poolListModelProvider = poolListModelProvider; Line 139: this.templateListModelProvider = templateListModelProvider; Line 140: this.userListModelProvider = userListModelProvider; Line 141: this.eventListModelProvider = eventListModelProvider; Line 142: // this.reportsListModelProvider = reportsListModelProvider; If code is not needed, please remove it Line 143: this.quotaListModelProvider = quotaListModelProvider; Line 144: this.volumeListModelProvider = volumeListModelProvider; Line 145: this.diskListModelProvider = diskListModelProvider; Line 146: this.networkListModelProvider = networkListModelProvider; Line 221: // Switch the selected item as neccessary. Line 222: ListModel oldSelectedItem = getSelectedItem(); Line 223: if (getHasSelectedTags() && oldSelectedItem != getHostList() && oldSelectedItem != getVolumeList() Line 224: && oldSelectedItem != getVmList() Line 225: && oldSelectedItem != getUserList()) { Please be consistent with refactoring and use condition per line in the whole if statement Line 226: setSelectedItem(getVmList()); Line 227: } else if (getHasSelectedTags() || hadSelectedTags) { Line 228: // Update search string only when selecting or de-selecting tags Line 229: String prefix = ""; //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/34193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a2f8915203f4a2b9868767419351ef7ac702891 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
