Francesco Romani has posted comments on this change. Change subject: core: removing CR char after encoding ......................................................................
Patch Set 4: Code-Review+1 codewise looks fine to me. this is why xml-rpc is different from json-rpc http://www.w3.org/TR/REC-xml/#sec-line-ends json-rpc transports the content verbatim, as encoded by base64 (thus with \r\n line break), while xml-rpc does this "user friendly simplification" also, you may find some excerpts from my commit message here: http://gerrit.ovirt.org/#/c/34203/1 worth to be pasted here to explain this mysterious and frustrating issue you just solved. -- To view, visit http://gerrit.ovirt.org/34201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
