Sahina Bose has posted comments on this change. Change subject: engine : VDS Command for geo-replication session create ......................................................................
Patch Set 16: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29833/16/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java: Line 159: GetGlusterVolumeRemoveBricksStatus("org.ovirt.engine.core.vdsbroker.gluster"), Line 160: GetGlusterVolumeGeoRepStatus("org.ovirt.engine.core.vdsbroker.gluster"), Line 161: GetGlusterVolumeGeoRepStatusDetail("org.ovirt.engine.core.vdsbroker.gluster"), Line 162: StopGlusterVolumeGeoRepSession("org.ovirt.engine.core.vdsbroker.gluster"), Line 163: GlusterVolumeGeoRepSessionCreate("org.ovirt.engine.core.vdsbroker.gluster"), Sorry, missed this before..but the general trend seems to be create the command names with verb first. Line 164: DeleteGlusterVolumeGeoRepSession("org.ovirt.engine.core.vdsbroker.gluster"), Line 165: CreatePasswordLessSSHSession("org.ovirt.engine.core.vdsbroker.gluster"), Line 166: SetNumberOfCpus("org.ovirt.engine.core.vdsbroker"), Line 167: UpdateVmPolicy("org.ovirt.engine.core.vdsbroker"), -- To view, visit http://gerrit.ovirt.org/29833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8164990c5c377481f1b1244ae548f7eca3066b6 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
