Sahina Bose has posted comments on this change.

Change subject: engine : VdsCommand for geo-rep session resume
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

Minor comment

http://gerrit.ovirt.org/#/c/32933/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java:

Line 402:     GlfsInitException(4572),
Line 403:     GlfsFiniException(4573),
Line 404:     GlusterGeoRepSessionDeleteFailedException(4594),
Line 405:     GlusterVolumeGeoRepStopFailedException(4596),
Line 406:     GlusterVolumeGeoRepResumeFailed(4597),
Please confirm this exception code with vdsm patch
Line 407:     GlusterVolumeGeoRepStatusFailed(4599),
Line 408:     GlusterVolumeGeoRepStatusDetailFailed(4600),
Line 409: 
Line 410:     UnicodeArgumentException(4900),


-- 
To view, visit http://gerrit.ovirt.org/32933
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1724dffbb4023e51a73d7262596f92bacb8698
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to