Einav Cohen has posted comments on this change.

Change subject: userportal,webadmin: preserve grid scroll
......................................................................


Patch Set 2:

> sure - will apply and report in a bit.

update:

I have tested the following scenario in Chrome 38 and FF31 on Fedora 19:

- within the Data-Centers main grid: scroll until 'ccc' is the first item 
displayed in the visible section. 
- refresh the grid a couple of times
- Chrome, Firefox: scroll is retained, i.e. 'ccc' is still displayed as 'first' 
[v]
- select the 'dc10' item in the grid [sub-tabs appear]
- Chrome, Firefox: scroll "jumps" to the top and slightly afterwards - goes 
'back' to displaying 'ccc' as first [?]
- refresh the main grid a couple of times
- Chrome, Firefox: scroll is retained [v]
- deselect the 'dc10' item in the grid [sub-tabs disappear]
- Firefox: scroll "jumps" to the top and slightly afterwards - goes 'back' to 
displaying 'ccc' as first [?]
- Chrome: scroll "jumps" all the way to the bottom [x]

Chrome: 
https://raw.githubusercontent.com/eco-public/clipboard/master/scrolling-Chrome.ogv

Firefox: 
https://raw.githubusercontent.com/eco-public/clipboard/master/scrolling-Firefox.ogv

need to look into the delays (marked with '[?]' above) and the strange Chrome 
behavior (marked with '[x]' above). 

Notes:

- I have tested Data-Centers, not Events or Users. 
- By default, the dev-env 'make' command-line compiles only for Firefox; make 
sure that you are using the 'BUILD_ALL_USER_AGENTS=1' option in the 'make' 
command or similar (see http://gerrit.ovirt.org/#/c/32164/), to ensure that 
indeed Chrome is loading a permutation targeted for it, rather than a 
permutation targeted for another browser. 

please let me know if I can further assist in any way.

-- 
To view, visit http://gerrit.ovirt.org/34211
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6affc48b93968a77329590bd15f13d0735c70a1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to