Vojtech Szocs has posted comments on this change. Change subject: webadmin: use new element-id-capable SortedColumn for vm statustext ......................................................................
Patch Set 1: Code-Review+2 (2 comments) > In the VM main tab, the 'status text' column lost its static element id, > probably when it was made into a SortedColumn or a composite column. I think it happened because the column was made composite. Anyway, this patch looks good to me. http://gerrit.ovirt.org/#/c/34210/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CellWithElementId.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CellWithElementId.java: Line 2: Line 3: import com.google.gwt.cell.client.Cell; Line 4: Line 5: // TODO I think all of our custom cells should implement this. No reason Line 6: // not to have IDs on every table cell. I agree, this can be done in steps (multiple smaller patches), modifying all our custom cells. Line 7: Line 8: /** Line 9: * A cell that sets an ID when it renders. Line 10: * http://gerrit.ovirt.org/#/c/34210/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java: Line 38: sb.appendHtmlConstant("<div id=\""); //$NON-NLS-1$ Line 39: sb.appendEscaped(ElementIdUtils.createTableCellElementId(getElementIdPrefix(), getColumnId(), context)); Line 40: sb.appendHtmlConstant("\">"); //$NON-NLS-1$ Line 41: Line 42: // TODO use my element id and column index > This is a stray TODO. I will remove. +1 Line 43: for (HasCell<VM, ?> hasCell : hasCells) { Line 44: render(context, value, sb, hasCell); Line 45: } Line 46: -- To view, visit http://gerrit.ovirt.org/34210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97bb0a04d46e94efede5f46af35ebcee01a9dd70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
