Francesco Romani has posted comments on this change.
Change subject: core: removing CR char after encoding
......................................................................
Patch Set 5: Verified+1 Code-Review+1
Verified with the same steps as per patch set #4.
Excerpt of the logs:
SRC:
Thread-5015::DEBUG::2014-10-20
12:10:25,726::__init__::467::jsonrpc.JsonRpcServer::(_serveRequest) Calling
'VM.create' in bridge with {u'vmParams': {u'acpiEnable': u'true',
u'emulatedMachine': u'rhel6.5.0', u'vmId':
u'39894abe-8c9b-497d-8edc-a972f91b7127', u'memGuaranteedSize': 1024,
u'transparentHugePages': u'true', u'spiceSslCipherSuite': u'DEFAULT',
u'cpuType': u'SandyBridge', u'smp': u'1', u'numaTune': {u'nodeset': u'0',
u'mode': u'interleave'}, u'custom': {}, u'vmType': u'kvm', u'memSize': 1024,
u'smpCoresPerSocket': u'1', u'vmName': u'f', u'nice': u'0', u'bootMenuEnable':
u'false', u'copyPasteEnable': u'true', u'smartcardEnable': u'false',
u'fileTransferEnable': u'true', u'keyboardLayout': u'en-us', u'kvmEnable':
u'true', u'displayNetwork': u'ovirtmgmt', u'devices': [{u'index': u'3',
u'iface': u'ide', u'specParams': {u'vmPayload': {u'volId': u'config-2',
u'file': {u'openstack/latest/meta_data.json':
u'ewogICJsYXVuY2hfaW5kZXgiIDogIjAiLAogICJhdmFpbGFiaWxpdHlfem9uZSIgOiAi!
bm92YSIsCiAgInV1aWQiIDogImNmNzhjMGEwLWM1MmMtNDNkYS1iZGIyLWFhMjJmMzgxYWI3NyIsCiAgIm1ldGEiIDogewogICAgImVzc2VudGlhbCIgOiAiZmFsc2UiLAogICAgInJvbGUiIDogInNlcnZlciIsCiAgICAiZHNtb2RlIiA6ICJsb2NhbCIKICB9Cn0=',
u'openstack/latest/user_data':
u'I2Nsb3VkLWNvbmZpZwpzc2hfcHdhdXRoOiB0cnVlCmRpc2FibGVfcm9vdDogMApvdXRwdXQ6CiAgYWxsOiAnPj4gL3Zhci9sb2cvY2xvdWQtaW5pdC1vdXRwdXQubG9nJwpjaHBhc3N3ZDoKICBleHBpcmU6IGZhbHNlCnJ1bmNtZDoKLSAnc2VkIC1pICcnL15kYXRhc291cmNlX2xpc3Q6IC9kJycgL2V0Yy9jbG91ZC9jbG91ZC5jZmc7IGVjaG8gJydkYXRhc291cmNlX2xpc3Q6CiAgWyJOb0Nsb3VkIiwgIkNvbmZpZ0RyaXZlIl0nJyA+PiAvZXRjL2Nsb3VkL2Nsb3VkLmNmZycK'}}},
u'readonly': u'true', u'deviceId': u'f5117637-d9be-4b65-9271-3077922eb481',
u'path': u'', u'device': u'cdrom', u'shared': u'false', u'type': u'disk'}
<devices>
<emulator>/usr/libexec/qemu-kvm</emulator>
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw'/>
<source startupPolicy='optional'/>
<target dev='hdc' bus='ide'/>
<readonly/>
<serial></serial>
<alias name='ide0-1-0'/>
<address type='drive' controller='0' bus='1' target='0' unit='0'/>
</disk>
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw'/>
<source
file='/var/run/vdsm/payload/39894abe-8c9b-497d-8edc-a972f91b7127.13d26b67d40d1fe1cb07a2683ba28acf.img'
startupPolicy='optional'/>
<target dev='hdd' bus='ide'/>
<readonly/>
<serial></serial>
<alias name='ide0-1-1'/>
<address type='drive' controller='0' bus='1' target='0' unit='1'/>
</disk>
DST:
2014-10-20 10:11:54.393+0000: 4125: debug : qemuProcessStart:3914 : Checking
for KVM availability
2014-10-20 10:11:54.393+0000: 4125: debug : qemuProcessStart:3924 : Determining
emulator version
2014-10-20 10:11:54.393+0000: 4125: debug : qemuCapsCacheLookup:2201 :
Returning caps 0x7f77680e71a0 for /usr/libexec/qemu-kvm
2014-10-20 10:11:54.393+0000: 4125: debug : qemuDomainCheckDiskPresence:2006 :
Checking for disk presence
2014-10-20 10:11:54.395+0000: 4125: debug : qemuProcessStart:3957 : Setting up
domain cgroup (if required)
2014-10-20 10:11:54.397+0000: 4125: debug : qemuProcessStart:3966 : Preparing
monitor state
<devices>
<emulator>/usr/libexec/qemu-kvm</emulator>
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw'/>
<source startupPolicy='optional'/>
<target dev='hdc' bus='ide'/>
<readonly/>
<serial></serial>
<alias name='ide0-1-0'/>
<address type='drive' controller='0' bus='1' target='0' unit='0'/>
</disk>
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw'/>
<source
file='/var/run/vdsm/payload/39894abe-8c9b-497d-8edc-a972f91b7127.13d26b67d40d1fe1cb07a2683ba28acf.img'
startupPolicy='optional'/>
<target dev='hdd' bus='ide'/>
<readonly/>
<serial></serial>
<alias name='ide0-1-1'/>
<address type='drive' controller='0' bus='1' target='0' unit='1'/>
</disk>
--
To view, visit http://gerrit.ovirt.org/34201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
