Moti Asayag has posted comments on this change.

Change subject: engine: Add AddVdsGroupOperationParameters class
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/33300/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsGroupOperationParameters.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsGroupOperationParameters.java:

Line 2: 
Line 3: import org.ovirt.engine.core.common.businessentities.VDSGroup;
Line 4: import org.ovirt.engine.core.compat.Guid;
Line 5: 
Line 6: public class AddVdsGroupOperationParameters extends 
VdsGroupOperationParameters {
please rename to AddClusterOperationParameters and respectively the c'tor 
arguments mames

or s/vdsGroup/cluster/g
Line 7: 
Line 8:     private static final long serialVersionUID = 1L;
Line 9: 
Line 10:     private Guid managementNetworkId;


-- 
To view, visit http://gerrit.ovirt.org/33300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41d6bb8cc882c9aa8bb0e3193f9785a2daf1c889
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to