Martin Mucha has uploaded a new change for review.

Change subject: userportal,webadmin: UICommand as a 'builder'.
......................................................................

userportal,webadmin: UICommand as a 'builder'.

there was some setters missing 'return this' syntaxt corrupting
'builder' style of this class.

Change-Id: I9ebc84df454f7204d098c78b7226deb2c511c387
Signed-off-by: Martin Mucha <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
1 file changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/34275/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
index c33f6a0..490ebd1 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
@@ -55,18 +55,17 @@
     /*
      * Call this method after adding execute prohibition reasons.
      */
-    public void setIsExecutionAllowed(boolean value)
-    {
-        if (isExecutionAllowed != value)
-        {
+    public UICommand setIsExecutionAllowed(boolean value) {
+        if (isExecutionAllowed != value) {
             isExecutionAllowed = value;
-            if (value)
-            {
+            if (value) {
                 getExecuteProhibitionReasons().clear();
             }
 
             onPropertyChanged(new 
PropertyChangedEventArgs("IsExecutionAllowed")); //$NON-NLS-1$
         }
+
+        return this;
     }
 
     private List<String> privateExecuteProhibitionReasons;
@@ -76,9 +75,9 @@
         return privateExecuteProhibitionReasons;
     }
 
-    public void setExecuteProhibitionReasons(List<String> value)
-    {
+    public UICommand setExecuteProhibitionReasons(List<String> value) {
         privateExecuteProhibitionReasons = value;
+        return this;
     }
 
     private boolean privateIsDefault;
@@ -101,9 +100,9 @@
         return privateIsVisible;
     }
 
-    public void setIsVisible(boolean value)
-    {
+    public UICommand setIsVisible(boolean value) {
         privateIsVisible = value;
+        return this;
     }
 
     private boolean privateIsCancel;
@@ -126,17 +125,18 @@
         return privateName;
     }
 
-    public void setName(String value)
-    {
+    public UICommand setName(String value) {
         privateName = value;
+        return this;
     }
 
     public ICommandTarget getTarget() {
         return target;
     }
 
-    public void setTarget(ICommandTarget target) {
+    public UICommand setTarget(ICommandTarget target) {
         this.target = target;
+        return this;
     }
 
     private ICommandTarget target;


-- 
To view, visit http://gerrit.ovirt.org/34275
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ebc84df454f7204d098c78b7226deb2c511c387
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to