Michael Kublin has posted comments on this change. Change subject: core: added snapshot id to attached disk (#834004) ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java Line 129: diskImage.setvm_snapshot_id(snapshotId); You wrote a code in order to make a test work. I mean u write a bad code which only purpose to make a test work. There are can not be a good test which is testing a bad test. "if any other developer will change the code and break it" - these is not a reason for writing a dead code -- To view, visit http://gerrit.ovirt.org/5718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0945cecc63dc041fdb56e2fd7b733b287a9904c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
