Maor Lipchuk has posted comments on this change. Change subject: core: Add number of monitors to OVF data ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34240/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java: Line 138: } Line 139: Line 140: protected void readUsbItem(XmlNode node) { Line 141: super.readUsbItem(node); Line 142: String numOfMonitors = node.SelectSingleNode("rasd:NumOfMonitors", _xmlNS).innerText; > This should be done in readMonitorItem, IIUC. The monitor will only be available if the Template will have a video device Line 143: if (StringUtils.isNotEmpty(numOfMonitors)) { Line 144: _vmTemplate.setNumOfMonitors(new Integer(numOfMonitors)); Line 145: } Line 146: } -- To view, visit http://gerrit.ovirt.org/34240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfdbbaa7f55476e6b2d064e0f2a456af4d40e86a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
