Idan Shaby has posted comments on this change.

Change subject: core: Empty Change CD List when ISO is Inactive
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/34031/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java:

Line 31:      * @param type
Line 32:      *            the storage domain type
Line 33:      * @return the master storage domain
Line 34:      */
Line 35:     StorageDomain getStorageDomain(Guid storagePoolId, 
StorageDomainType type);
> In the other methods in this class you call it poolId.
Done
Line 36: 
Line 37:     /**
Line 38:      * Retrieves the storage domain for the specified pool, type and 
status.
Line 39:      *


-- 
To view, visit http://gerrit.ovirt.org/34031
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I784be2510e2f51be277f7ee06a5bd5573ab23d66
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to