Idan Shaby has posted comments on this change. Change subject: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34029/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-08 08:45:24 +0300 Line 4: Commit: Idan Shaby <[email protected]> Line 5: CommitDate: 2014-10-20 14:37:28 +0300 Line 6: Line 7: core: Renamed the Method getStorageDomainByTypeAndPool > The fact that you're talking about StorageDomainDAO's method should be ment Done Line 8: Line 9: The method's parameters types are clear enough, so there's no need to Line 10: include them also in the method's name. Line 11: -- To view, visit http://gerrit.ovirt.org/34029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
