Alona Kaplan has posted comments on this change. Change subject: engine: update AddVdsGroupCommand ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/33416/8/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTest.java: Line 137: } Line 138: Line 139: @Test Line 140: public void managementNetworkChangeValidNoChangeAfterAttachment1() { Line 141: testManagementNetworkChangeAfterAttachement(null, Boolean.FALSE, false, network, isValid()); > This test should fail- you shouldn't be able to change the mgmt network to Ignore the previous comment- you don't need this test at all. On AttachNetwork to cluster the validator assumes the current mgmgt network is not the one being attached. Line 142: } Line 143: Line 144: @Test Line 145: public void managementNetworkChangeValidNoChangeAfterAttachment2() { Line 141: testManagementNetworkChangeAfterAttachement(null, Boolean.FALSE, false, network, isValid()); Line 142: } Line 143: Line 144: @Test Line 145: public void managementNetworkChangeValidNoChangeAfterAttachment2() { You don't need this test. On AttachNetwork to cluster the validator assumes the current mgmgt network is not the one being attached. Line 146: testManagementNetworkChangeAfterAttachement(null, Boolean.TRUE, false, network, isValid()); Line 147: } Line 148: Line 149: @Test -- To view, visit http://gerrit.ovirt.org/33416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I196a583ae7d8d7e373a1aca2a48e592232b18a5b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
