Alon Bar-Lev has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll/job ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/34324/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java: Line 159: JobRepositoryFactory.getJobRepository().updateStep(step); Line 160: } Line 161: } Line 162: } catch (Exception e) { Line 163: log.error("Failed to terminate step '{}' with status '{}'", stepId, exitStatus); still better to put the e.getMessage() so we can reduce the level of the stack dumps easily. Line 164: log.error("Exception", e); Line 165: } Line 166: } Line 167: -- To view, visit http://gerrit.ovirt.org/34324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1546a4b1183442aa0a8784e722442e9ddd09d716 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
