mooli tayer has posted comments on this change. Change subject: notifier: modify the oid schema for SNMP notification. ......................................................................
Patch Set 14: Verified-1 (1 comment) failed. http://gerrit.ovirt.org/#/c/32951/14/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java: Line 178: } Line 179: // { [baseoid] objects(2) audit(1) } Line 180: OID auditObjects = new OID(profile.oid).append(OBJECTS_AUDIT); Line 181: Line 182: addInt(v2pdu, auditObjects, INSTANCE_ID, auditLogId, true); above is wrong, should be event.getId(), I will send string for now to avoid overflowing problems (int/long) Line 183: addString(v2pdu, auditObjects, NAME, event.getName(), true); Line 184: addInt(v2pdu, auditObjects, ID, auditLogId, true); Line 185: addInt(v2pdu, auditObjects, SEVERITY, event.getSeverity().getValue(), true); Line 186: addString(v2pdu, auditObjects, MESSAGE, event.getMessage(), true); -- To view, visit http://gerrit.ovirt.org/32951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8a06063f8ebbbe4d05783cb25036e870a6be3b7 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
