Jenny Kang has posted comments on this change. Change subject: Added more tests to ovirt.js ......................................................................
Patch Set 2: (1 comment) rebased to the new changes committed and changed resource tests http://gerrit.ovirt.org/#/c/34224/2/frontend/ovirtjs/src/test/ResponseSpec.js File frontend/ovirtjs/src/test/ResponseSpec.js: Line 6: id: 'test', Line 7: href: '/api' Line 8: }); Line 9: Line 10: expect(resource.apiContextPath).toEqual('/api'); > This is a good start, you could do more expectations to inspect different p Yes, I just pushed in a new commit with these changes. Line 11: }); -- To view, visit http://gerrit.ovirt.org/34224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c445d76dacd36291183c9384eb95a5b555ce58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Kang <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Jenny Kang <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
