Oved Ourfali has posted comments on this change. Change subject: core: protocol fall back for older vdsms ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34098/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java: Line 26: */ Line 27: public class ProtocolDetector { Line 28: Line 29: private static final Integer CONNECT_WAIT = 5000; Line 30: private static final Integer NUMBER_OF_ATTEMPTS = 3; I talked about that with Barak. Let's put these two as configurable, just in case it will require tuning. Line 31: Line 32: private VDS vds; Line 33: Line 34: public ProtocolDetector(VDS vds) { -- To view, visit http://gerrit.ovirt.org/34098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
