Oved Ourfali has posted comments on this change.

Change subject: core: protocol fall back for older vdsms
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/34255/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java:

Line 75:      * Timeout in milliseconds to wait between connection attempt 
during protocol fallback.
Line 76:      */
Line 77:     @TypeConverterAttribute(Integer.class)
Line 78:     @DefaultValueAttribute("5000")
Line 79:     protocolFallbackTimeoutInMilliSeconds,
s/protocol/Protocol
Line 80: 
Line 81:     @TypeConverterAttribute(Integer.class)
Line 82:     @DefaultValueAttribute("2")
Line 83:     VdsRefreshRate,


http://gerrit.ovirt.org/#/c/34255/3/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql:

Line 674: select 
fn_db_add_config_value('VdsLocalDisksLowFreeSpace','500','general');
Line 675: select 
fn_db_add_config_value('VdsRecoveryTimeoutInMinutes','3','general');
Line 676: select fn_db_add_config_value('VdsRefreshRate','2','general');
Line 677: select fn_db_add_config_value('vdsRetries','0','general');
Line 678: select 
fn_db_add_config_value('protocolFallbackRetries','3','general');
s/protocol/Protocol.
Line 679: select 
fn_db_add_config_value('protocolFallbackTimeoutInMilliSeconds','5000','general');
Line 680: --Handling Host Selection Algorithm default for cluster
Line 681: select 
fn_db_add_config_value('VdsSelectionAlgorithm','None','general');
Line 682: select fn_db_add_config_value('vdsTimeout','180','general');


-- 
To view, visit http://gerrit.ovirt.org/34255
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9af3129a4adf839f2d4c2e110425a6c69e45256
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to