Eli Mesika has posted comments on this change. Change subject: core: Added the table vds_deploy_config ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/27028/10/packaging/dbscripts/vds_deploy_custumization_environment_sp.sql File packaging/dbscripts/vds_deploy_custumization_environment_sp.sql: Line 12: v_env_id := CURRVAL('vds_deploy_custumization_environment_seq'); Line 13: END; $procedure$ Line 14: LANGUAGE plpgsql; Line 15: Line 16: please remove all duplicate empty lines , only one line between procedures Line 17: Line 18: Line 19: Line 20: Create or replace FUNCTION UpdateVdsDeployCustomizationEnvironment( Line 73: Line 74: Line 75: Line 76: Line 77: Create or replace FUNCTION GetVdsDeployCustomizationEnvironmentByNameAndType(v_env_name VARCHAR(50), v_env_type VARCHAR(30)) RETURNS SETOF vds_deploy_custumization_environment STABLE please remove redundant space before : STABLE Line 78: AS $procedure$ Line 79: BEGIN Line 80: RETURN QUERY SELECT vds_deploy_custumization_environment.* Line 81: FROM vds_deploy_custumization_environment Line 78: AS $procedure$ Line 79: BEGIN Line 80: RETURN QUERY SELECT vds_deploy_custumization_environment.* Line 81: FROM vds_deploy_custumization_environment Line 82: WHERE env_name = v_env_name and env_type = v_env_type; WHERE env_name = v_env_name and env_type = v_env_type; Line 83: END; $procedure$ Line 84: LANGUAGE plpgsql; Line 85: Line 86: -- To view, visit http://gerrit.ovirt.org/27028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc58b36dccfd23165dd5b0dfb7c2c86cf261f488 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
