Alon Bar-Lev has posted comments on this change. Change subject: core: remove ovirt logger from vdsbroker and friends ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/34374/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java: Line 26: } Line 27: Line 28: public void execute() { Line 29: String logId = LoggedUtils.getObjectId(this); Line 30: LoggedUtils.logEntry(log, logId, this); > Do we still need to use LoggedUtils? probably... lots of places. Line 31: Line 32: try { Line 33: executeCommand(); Line 34: LoggedUtils.logReturn(log, logId, this, getReturnValue() != null && getReturnValue() instanceof Map[] ? Arrays.asList((Map[])getReturnValue()) : getReturnValue()); http://gerrit.ovirt.org/#/c/34374/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 173: getVDSReturnValue().setVdsError(new VDSError(VdcBllErrors.VDS_NETWORK_ERROR, ex.getMessage())); Line 174: if (ExceptionUtils.getRootCause(ex) != null) { Line 175: logException(ExceptionUtils.getRootCause(ex)); Line 176: } else { Line 177: LoggedUtils.logError(log, LoggedUtils.getObjectId(this), this, ex); > Same question for this class. Do we need to use LoggedUtils? not sure... but removing LoggedUtils is in future work... Line 178: } Line 179: failover(); Line 180: } catch (XmlRpcRunTimeException ex) { Line 181: getVDSReturnValue().setExceptionString(ex.toString()); -- To view, visit http://gerrit.ovirt.org/34374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae367e2c2fe3df862c8a345ca73575198f4c6edd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
